Repository navigation
fix(windows): close skill-markdown graph clients to avoid sqlite EBUSY - #58
Merged
Merged
Conversation
Import, export, and dialogue-knowledge extract opened a graph client and returned without close(). On Windows the default sqlite transport then left graphflow-graph.sqlite locked, so cleanup failed with EBUSY. Fixes #53
Roarpeng
marked this pull request as ready for review
October 7, 2026 09:42
… fix CHANGELOG conflicted after #57. Both Unreleased notes stay: the MCP SDK and proxy-addr override, and closing skill-markdown graph clients. Co-authored-by: RoarPeng <Roarpeng@users.noreply.github.com>
cursor Bot
pushed a commit
that referenced
this pull request
Oct 7, 2026
… fix CHANGELOG conflicted after #58. Both Unreleased notes stay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
validate-platforms (windows-latest)failed in skill-markdown tests with:Default
graphPolicy.transportisauto(sqlite whenbetter-sqlite3is present).importSkillsFromMarkdownRuntime,exportSkillsToMarkdownRuntime, andextractDialogueKnowledgeRuntimeopened a graph client and neverclose()'d it. On Windows that lock blocksrmSyncof the temp workspace.Changes
await client.close()infinally, including when a later write throws.close()ran. Existing progressive/interop suites still pass.Validation
npx vitest run tests/skill-markdown-client-close.test.ts tests/skill-markdown-progressive.test.ts tests/skill-markdown-interop.test.ts— 19 passed (Linux).Windows file locks are not reproducible on this Linux agent. The fix is the same handle release the sqlite client already uses elsewhere (
close()callsbetter-sqlite3'sdb.close()). The new test asserts the runtime invokesclose()before returning, which is what lets Windows unlinkgraphflow-graph.sqlite. CI jobvalidate-platforms (windows-latest)is the platform check.Fixes #53